Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't send error in stats #4055

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: don't send error in stats #4055

merged 2 commits into from
Nov 1, 2023

Conversation

achettyiitr
Copy link
Member

Description

  • Don't send errors in the stats as it can increase the cardinality.

Linear Ticket

  • Resolves PIPE-465

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d2db45) 71.52% compared to head (9d2d8c2) 71.79%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4055      +/-   ##
==========================================
+ Coverage   71.52%   71.79%   +0.27%     
==========================================
  Files         373      373              
  Lines       54838    54837       -1     
==========================================
+ Hits        39224    39372     +148     
+ Misses      13275    13149     -126     
+ Partials     2339     2316      -23     
Files Coverage Δ
enterprise/reporting/error_index/types.go 42.85% <ø> (ø)
warehouse/router/router.go 88.14% <100.00%> (+0.56%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants