Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor formatting changes #4079

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: minor formatting changes #4079

merged 1 commit into from
Nov 6, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Nov 6, 2023

Description

  • Receiver names are different
  • Unused constant
  • Unused parameter
  • Unused exported function
  • Redundant type conversion
  • Unhandled error
  • Type assertion on errors fails on wrapped errors

Linear Ticket

  • Resolves PIPE-494

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6583364) 71.78% compared to head (8606f6f) 71.92%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4079      +/-   ##
==========================================
+ Coverage   71.78%   71.92%   +0.13%     
==========================================
  Files         372      373       +1     
  Lines       54984    54969      -15     
==========================================
+ Hits        39472    39536      +64     
+ Misses      13187    13114      -73     
+ Partials     2325     2319       -6     
Files Coverage Δ
warehouse/api/grpc.go 81.94% <100.00%> (ø)
warehouse/client/client.go 61.97% <100.00%> (-0.53%) ⬇️
warehouse/internal/repo/upload.go 91.39% <100.00%> (ø)
warehouse/router/upload.go 70.85% <ø> (-0.91%) ⬇️
warehouse/utils/utils.go 84.61% <ø> (+2.87%) ⬆️
...se/integrations/datalake/schema-repository/glue.go 77.29% <62.50%> (-0.04%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants