Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt health.WaitUntilReady #4081

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

achettyiitr
Copy link
Member

Description

  • Adapt health.WaitUntilReady

Linear Ticket

  • Resolves PIPE-495

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

warehouse/app_test.go Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6583364) 71.78% compared to head (595e932) 71.80%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4081      +/-   ##
==========================================
+ Coverage   71.78%   71.80%   +0.02%     
==========================================
  Files         372      373       +1     
  Lines       54984    54982       -2     
==========================================
+ Hits        39472    39482      +10     
+ Misses      13187    13177      -10     
+ Partials     2325     2323       -2     
Files Coverage Δ
warehouse/router/state.go 100.00% <100.00%> (ø)
warehouse/router/upload.go 70.85% <100.00%> (-0.91%) ⬇️
warehouse/router/identities.go 19.83% <0.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit c11b4db into master Nov 6, 2023
36 checks passed
@cisse21 cisse21 deleted the chore.health.wait-until-ready branch November 6, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants