-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update destination id label to be consistent with other modules #4992
chore: update destination id label to be consistent with other modules #4992
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4992 +/- ##
==========================================
+ Coverage 74.41% 74.45% +0.03%
==========================================
Files 428 428
Lines 49909 49915 +6
==========================================
+ Hits 37140 37162 +22
+ Misses 10327 10317 -10
+ Partials 2442 2436 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use destinationId
everywhere. Also we might need to update the grafana dashboard.
For |
Description
We use different destination label keys for
event_delivery_time
metric for different modules, for router and warehouse we are usingdestID
and for batch_router we are usingdestinationId
.Changing destination id label for batch_router module to be consistent with other modules.
Linear Ticket
Resolves OBS-586
https://linear.app/rudderstack/issue/OBS-586/update-labels-in-event-delivery-time-metric
Security