Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snowpipe streaming #5110

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

achettyiitr
Copy link
Member

Description

  • Integrated new destination Snowpipe Streaming as part of async destination.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 8 times, most recently from 68163a6 to 5607206 Compare September 23, 2024 08:53
@achettyiitr achettyiitr marked this pull request as draft September 23, 2024 20:02
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 4 times, most recently from b34de25 to 444da09 Compare September 23, 2024 23:28
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 72.89003% with 106 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (336b876) to head (f569ead).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
...tionmanager/snowpipestreaming/snowpipestreaming.go 71.37% 50 Missing and 23 partials ⚠️
warehouse/utils/uploader.go 5.55% 17 Missing ⚠️
...tinationmanager/snowpipestreaming/createchannel.go 80.00% 2 Missing and 2 partials ⚠️
...tinationmanager/snowpipestreaming/deletechannel.go 76.47% 2 Missing and 2 partials ⚠️
...syncdestinationmanager/snowpipestreaming/insert.go 85.18% 2 Missing and 2 partials ⚠️
...syncdestinationmanager/snowpipestreaming/status.go 88.23% 1 Missing and 1 partial ⚠️
testhelper/warehouse/records.go 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5110      +/-   ##
==========================================
+ Coverage   73.12%   73.79%   +0.67%     
==========================================
  Files         437      445       +8     
  Lines       50787    51174     +387     
==========================================
+ Hits        37136    37762     +626     
+ Misses      11229    10933     -296     
- Partials     2422     2479      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added Stale and removed Stale labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant