Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce batch read for scylla #5212

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Oct 21, 2024

Description

  • Speed up the read step and avoid network delays by introducing batch reads in scylla
  • Refactored processorJobsForDest to be able to accommodate batch reads for dedup

Linear Ticket

Fixes PIPE-1651

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 changed the title fix: dedup - use writeBatch to put keys in badger (#5204) fix: use writeBatch to put keys in badger Oct 21, 2024
@cisse21 cisse21 changed the title fix: use writeBatch to put keys in badger feat: introduce batch read for scylla Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 84.75610% with 100 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (da9f8c8) to head (256b4c4).

Files with missing lines Patch % Lines
processor/processor.go 85.04% 63 Missing and 20 partials ⚠️
services/dedup/badger/badger.go 60.00% 4 Missing and 2 partials ⚠️
services/dedup/mirrorBadger/mirrorBadger.go 57.14% 2 Missing and 1 partial ⚠️
services/dedup/mirrorScylla/mirrorScylla.go 57.14% 2 Missing and 1 partial ⚠️
services/dedup/scylla/scylla.go 95.08% 2 Missing and 1 partial ⚠️
processor/worker.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5212      +/-   ##
==========================================
+ Coverage   73.19%   73.20%   +0.01%     
==========================================
  Files         417      417              
  Lines       59085    59529     +444     
==========================================
+ Hits        43246    43581     +335     
- Misses      13426    13512      +86     
- Partials     2413     2436      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from a422eae to fbb2a5f Compare October 21, 2024 09:37
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch 2 times, most recently from 543e741 to 913f3fc Compare October 21, 2024 10:46
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from 913f3fc to 6695ac4 Compare October 21, 2024 12:27
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from 6695ac4 to 8f61a4c Compare October 21, 2024 15:19
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch 7 times, most recently from 3fdf8b8 to 9a14c25 Compare October 22, 2024 16:47
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch 3 times, most recently from 052423f to 09cecc6 Compare October 22, 2024 17:32
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch 3 times, most recently from 767e8ec to 05e4247 Compare October 22, 2024 18:32
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from 05e4247 to 12af024 Compare October 22, 2024 18:46
@cisse21 cisse21 marked this pull request as ready for review October 22, 2024 18:55
processor/worker.go Outdated Show resolved Hide resolved
services/dedup/scylla/scylla.go Outdated Show resolved Hide resolved
services/dedup/scylla/scylla.go Outdated Show resolved Hide resolved
processor/worker.go Outdated Show resolved Hide resolved
services/dedup/scylla/scylla.go Outdated Show resolved Hide resolved
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from 5a0488f to a6b3577 Compare October 23, 2024 07:52
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from a6b3577 to d5487ae Compare October 23, 2024 08:46
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from d5487ae to fde3950 Compare October 23, 2024 09:54
Copy link

@ktgowtham ktgowtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

processor/processor.go Show resolved Hide resolved
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch 2 times, most recently from 173d622 to 4cdefcd Compare October 23, 2024 10:49
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch 2 times, most recently from 9d204ea to 0b86910 Compare October 23, 2024 18:11
@cisse21 cisse21 force-pushed the chore.refactorprocessJobsForDest branch from 0b86910 to 256b4c4 Compare October 23, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants