Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json marshal l errors when parsing poll response from klaviyo #5316

Open
wants to merge 2 commits into
base: release/1.38.x
Choose a base branch
from

Conversation

koladilip
Copy link
Contributor

Description

There is a bug in the Klaviyo implementation where, at times, we receive an empty import ID from the upload. However, when we poll with an empty import ID, we encounter parsing errors because Klaviyo returns a list response when the import ID is empty.

Linear Ticket

https://linear.app/rudderstack/issue/INT-2820/klaviyo-bulk-upload-at-times-they-are-running-into-errors
Resolves INT-2820

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.47%. Comparing base (e4cb7f1) to head (b9504e3).

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 12.50% 7 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.38.x    #5316      +/-   ##
==================================================
+ Coverage           73.43%   73.47%   +0.03%     
==================================================
  Files                 425      425              
  Lines               59973    59981       +8     
==================================================
+ Hits                44044    44072      +28     
+ Misses              13450    13440      -10     
+ Partials             2479     2469      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@@ -106,7 +106,9 @@ func (kbu *KlaviyoBulkUploader) Poll(pollInput common.AsyncPoll) common.PollStat
importStatuses := make(map[string]string)
failedImports := make([]string, 0)
for _, importId := range importIds {
importStatuses[importId] = "queued"
if importId != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean all the events that were part of unsuccessful upload gets re-tried in next attempt as they don't get marked as queued ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants