chore: addressed review comments

rudderlabs · May 28, 2024 · ad86160 · ad86160
1 parent c90f42e
commit ad86160
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 39 deletions.
diff --git a/...nations/fb_custom_audience/transformV2.js → ...ons/fb_custom_audience/recordTransform.js b/...nations/fb_custom_audience/transformV2.js → ...ons/fb_custom_audience/recordTransform.js
@@ -4,28 +4,26 @@ const get = require('get-value');
 const {
   InstrumentationError,
   ConfigurationError,
-  TransformationError,
   getErrorRespEvents,
 } = require('@rudderstack/integrations-lib');
-const { schemaFields, typeFields, subTypeFields, getEndPoint } = require('./config');
+const { schemaFields } = require('./config');
 const { MappedToDestinationKey } = require('../../../constants');
 const stats = require('../../../util/stats');
 const {
   getDestinationExternalIDInfoForRetl,
   isDefinedAndNotNullAndNotEmpty,
   checkSubsetOfArray,
-  defaultRequestConfig,
   returnArrayOfSubarrays,
   getSuccessRespEvents,
-  defaultPostRequestConfig,
-  defaultDeleteRequestConfig,
   generateErrorObject,
 } = require('../../util');
 const {
   ensureApplicableFormat,
   getUpdatedDataElement,
   getSchemaForEventMappedToDest,
   batchingWithPayloadSize,
+  responseBuilderSimple,
+  getDataSource,
 } = require('./util');
 
 function getErrorMetaData(inputs, acceptedOperations) {
@@ -41,37 +39,6 @@ function getErrorMetaData(inputs, acceptedOperations) {
   return metadata;
 }
 
-const getDataSource = (type, subType) => {
-  const dataSource = {};
-  if (type && type !== 'NA' && typeFields.includes(type)) {
-    dataSource.type = type;
-  }
-  if (subType && subType !== 'NA' && subTypeFields.includes(subType)) {
-    dataSource.sub_type = subType;
-  }
-  return dataSource;
-};
-
-const responseBuilderSimple = (payload, audienceId) => {
-  if (payload) {
-    const responseParams = payload.responseField;
-    const response = defaultRequestConfig();
-    response.endpoint = getEndPoint(audienceId);
-
-    if (payload.operationCategory === 'add') {
-      response.method = defaultPostRequestConfig.requestMethod;
-    }
-    if (payload.operationCategory === 'remove') {
-      response.method = defaultDeleteRequestConfig.requestMethod;
-    }
-
-    response.params = responseParams;
-    return response;
-  }
-  // fail-safety for developer error
-  throw new TransformationError(`Payload could not be constructed`);
-};
-
 const processRecordEventArray = (
   recordChunksArray,
   userSchema,
@@ -307,6 +274,4 @@ async function processRecordInputs(groupedRecordInputs) {
 
 module.exports = {
   processRecordInputs,
-  responseBuilderSimple,
-  getDataSource,
 };
diff --git a/src/v0/destinations/fb_custom_audience/transform.js b/src/v0/destinations/fb_custom_audience/transform.js
@@ -14,11 +14,13 @@ const {
   getSchemaForEventMappedToDest,
   batchingWithPayloadSize,
   generateAppSecretProof,
+  responseBuilderSimple,
+  getDataSource,
 } = require('./util');
 const { schemaFields, USER_ADD, USER_DELETE } = require('./config');
 
 const { MappedToDestinationKey } = require('../../../constants');
-const { processRecordInputs, responseBuilderSimple, getDataSource } = require('./transformV2');
+const { processRecordInputs } = require('./recordTransform');
 
 function extraKeysPresent(dictionary, keyList) {
   // eslint-disable-next-line no-restricted-syntax

diff --git a/src/v0/destinations/fb_custom_audience/util.js b/src/v0/destinations/fb_custom_audience/util.js
@@ -4,6 +4,13 @@ const crypto = require('crypto');
 const get = require('get-value');
 const jsonSize = require('json-size');
 const { InstrumentationError, ConfigurationError } = require('@rudderstack/integrations-lib');
+const { TransformationError } = require('@rudderstack/integrations-lib');
+const { typeFields, subTypeFields, getEndPoint } = require('./config');
+const {
+  defaultRequestConfig,
+  defaultPostRequestConfig,
+  defaultDeleteRequestConfig,
+} = require('../../util');
 const stats = require('../../../util/stats');
 
 const { isDefinedAndNotNull } = require('../../util');
@@ -220,11 +227,44 @@ const generateAppSecretProof = (accessToken, appSecret, dateNow) => {
   return appsecretProof;
 };
 
+const getDataSource = (type, subType) => {
+  const dataSource = {};
+  if (type && type !== 'NA' && typeFields.includes(type)) {
+    dataSource.type = type;
+  }
+  if (subType && subType !== 'NA' && subTypeFields.includes(subType)) {
+    dataSource.sub_type = subType;
+  }
+  return dataSource;
+};
+
+const responseBuilderSimple = (payload, audienceId) => {
+  if (payload) {
+    const responseParams = payload.responseField;
+    const response = defaultRequestConfig();
+    response.endpoint = getEndPoint(audienceId);
+
+    if (payload.operationCategory === 'add') {
+      response.method = defaultPostRequestConfig.requestMethod;
+    }
+    if (payload.operationCategory === 'remove') {
+      response.method = defaultDeleteRequestConfig.requestMethod;
+    }
+
+    response.params = responseParams;
+    return response;
+  }
+  // fail-safety for developer error
+  throw new TransformationError(`Payload could not be constructed`);
+};
+
 module.exports = {
   prepareDataField,
   getSchemaForEventMappedToDest,
   batchingWithPayloadSize,
   ensureApplicableFormat,
   getUpdatedDataElement,
   generateAppSecretProof,
+  responseBuilderSimple,
+  getDataSource,
 };