fix: comments addressed

rudderlabs · Nov 13, 2024 · ec1751c · ec1751c
1 parent db5669b
commit ec1751c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/v0/destinations/google_adwords_enhanced_conversions/transform.js b/src/v0/destinations/google_adwords_enhanced_conversions/transform.js
@@ -45,13 +45,9 @@ const responseBuilder = async (metadata, message, { Config }, payload) => {
   let { customerId, loginCustomerId } = Config;
   const { configData } = Config;
 
-  let configDetails = {};
-  if (isDefinedAndNotNull(configData)) {
-    configDetails = JSON.parse(configData);
+  const configDetails = isDefinedAndNotNull(configData) ? JSON.parse(configData) : {};
+  if (configDetails.customerId) {
     customerId = configDetails.customerId;
-    if (isDefined(configDetails.loginCustomerId)) {
-      loginCustomerId = configDetails.loginCustomerId;
-    }
   }
 
   if (isNumber(customerId)) {

diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts
@@ -1,5 +1,3 @@
-import { API_VERSION } from '../../../../../src/v0/destinations/google_adwords_enhanced_conversions/config';
-
 const events = [
   {
     metadata: {
@@ -429,6 +427,7 @@ const events = [
         configData: '{"customerId":"1234567890", "loginCustomerId":"65656565"}',
         customerId: '1234567890',
         subAccount: true,
+        loginCustomerId: '65656565',
         listOfConversions: [{ conversions: 'Page View' }, { conversions: 'Product Added' }],
         authStatus: 'active',
       },
@@ -1080,6 +1079,7 @@ export const data = [
                   authStatus: 'active',
                   configData: '{"customerId":"1234567890", "loginCustomerId":"65656565"}',
                   customerId: '1234567890',
+                  loginCustomerId: '65656565',
                   listOfConversions: [
                     {
                       conversions: 'Page View',