Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(INT-568): slack send event to event specific channel based on channel webhook #2563

Merged
merged 7 commits into from
Sep 15, 2023
Merged

fix(INT-568): slack send event to event specific channel based on channel webhook #2563

merged 7 commits into from
Sep 15, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Previously we were sending messages to specific channels based on event using channel name But now slack has deprecated the feature to override the default channel due which now instead of event<>channelName mapping we are switching to event<>channelWebhook mapping.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 requested a review from a team as a code owner September 7, 2023 08:42
@anantjain45823 anantjain45823 self-assigned this Sep 7, 2023
@anantjain45823 anantjain45823 requested a review from a team as a code owner September 7, 2023 08:42
@anantjain45823 anantjain45823 mentioned this pull request Sep 7, 2023
Closed
10 tasks
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.29% and project coverage change: +0.04% 🎉

Comparison is base (2b38e2c) 86.83% compared to head (954d140) 86.87%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2563      +/-   ##
===========================================
+ Coverage    86.83%   86.87%   +0.04%     
===========================================
  Files          603      603              
  Lines        28158    28169      +11     
  Branches      6700     6701       +1     
===========================================
+ Hits         24450    24471      +21     
+ Misses        3371     3361      -10     
  Partials       337      337
Files Changed Coverage Δ
src/v0/destinations/slack/util.js 92.85% <ø> (ø)
src/v0/destinations/slack/transform.js 94.37% <96.29%> (+7.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mihir-4116
mihir-4116 reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@mihir-4116 mihir-4116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mihir-4116
mihir-4116 previously approved these changes Sep 15, 2023
View reviewed changes
@anantjain45823 anantjain45823 changed the base branch from main to develop September 15, 2023 08:22
@anantjain45823 anantjain45823 dismissed mihir-4116’s stale review September 15, 2023 08:22

The base branch was changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

88.3% 88.3% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 0f3b39e into develop Sep 15, 2023
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
@anantjain45823 @Sanjay-Veernala
fix(INT-568): slack send event to event specific channel based on cha…
d044663 
…nnel webhook (#2563)

* fix: slack send event to event specific channel

* small fixes

* incorporated legacy method

* added test cases and small fixes

* fixed payload for modern webhooks for not sending app details

* feat:added blacklisted event option
@anantjain45823 anantjain45823 deleted the fix.slackChannelMapping branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir-4116 mihir-4116 mihir-4116 approved these changes

@sanpj2292 sanpj2292 sanpj2292 approved these changes

@krishna2020 krishna2020 Awaiting requested review from krishna2020

Assignees

@anantjain45823 anantjain45823

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anantjain45823 @sanpj2292 @mihir-4116