Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message for HS #2576

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Sep 10, 2023

Description of the change

Resolves INT-508
Improve error message for mapping related configuration error in Hubspot

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai self-assigned this Sep 10, 2023
@yashasvibajpai yashasvibajpai requested review from a team as code owners September 10, 2023 09:04
@yashasvibajpai yashasvibajpai changed the title chore: improce error message for HS chore: improve error message for HS Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3c328e) 86.85% compared to head (639f614) 86.85%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2576   +/-   ##
========================================
  Coverage    86.85%   86.85%           
========================================
  Files          567      567           
  Lines        27964    27964           
  Branches      6661     6661           
========================================
  Hits         24288    24288           
  Misses        3342     3342           
  Partials       334      334           
Files Changed Coverage Δ
src/v0/destinations/hs/util.js 96.03% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yashasvibajpai yashasvibajpai merged commit c1f9d31 into develop Sep 11, 2023
@yashasvibajpai yashasvibajpai deleted the chore.improve.hs.err.message branch September 11, 2023 06:12
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
chore: improce error message for HS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants