feat: introduce de-activation of authStatus for access_denied or inva… #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid_grant errors Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
…to feat.oauth-access-denied-handling
|
Can you share the link to the rudder-server PR corresponding to these changes, if any? |
|
saikumarrs
reviewed
Sep 12, 2023
src/v0/destinations/google_adwords_enhanced_conversions/networkHandler.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
…able_dest Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2598 +/- ##
========================================
Coverage 86.87% 86.87%
========================================
Files 603 603
Lines 28169 28126 -43
Branches 6701 6692 -9
========================================
- Hits 24471 24434 -37
+ Misses 3361 3356 -5
+ Partials 337 336 -1
☔ View full report in Codecov by Sentry. |
added 5 commits
September 14, 2023 15:57
…nd access-token Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
…to feat.oauth-access-denied-handling
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
…to feat.oauth-access-denied-handling
saikumarrs
approved these changes
Sep 14, 2023
…to feat.oauth-access-denied-handling
sanpj2292
requested review from
krishna2020,
utsabc,
koladilip and
ItsSudip
koladilip
approved these changes
Sep 15, 2023
…to feat.oauth-access-denied-handling
|
Kudos, SonarCloud Quality Gate passed! |
Sanjay-Veernala
pushed a commit
that referenced
this pull request
Sep 20, 2023
#2598) * feat: introduce de-activation of authStatus for access_denied or invalid_grant errors Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: test-cases-1 Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: remove all references of disable_dest and remove the const disable_dest Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * chore: refactor to use util methods for getting auth error category and access-token Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: pardot router component test failure and remove unnecessary code Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: remove unused code --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Introducing de-activation of authStatus for access_denied or invalid_grant errors that we receive from destination
More details about the feature are provided here
Type of change
Related issues
Checklists
Development
Code review