Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(INT-339): marketo response handler to handle static list removed and skipped statuses" #2619

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Revert "fix(INT-339): marketo response handler to handle static list removed and skipped statuses" #2619

merged 1 commit into from
Sep 15, 2023

Conversation

anantjain45823
Copy link
Contributor

Reverts #2606

@anantjain45823
Revert "fix(INT-339): marketo response handler to handle static list …
500f645 
…removed and skipped statuses (#2606)"

This reverts commit e3fed49.
@anantjain45823 anantjain45823 requested review from a team as code owners September 15, 2023 05:55
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.02% ⚠️

Comparison is base (e3fed49) 86.84% compared to head (500f645) 86.83%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2619      +/-   ##
===========================================
- Coverage    86.84%   86.83%   -0.02%     
===========================================
  Files          603      603              
  Lines        28163    28158       -5     
  Branches      6702     6700       -2     
===========================================
- Hits         24459    24450       -9     
- Misses        3370     3371       +1     
- Partials       334      337       +3
Files Changed Coverage Δ
src/v0/destinations/marketo/util.js 85.00% <40.00%> (-5.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

43.3% 43.3% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 2b38e2c into develop Sep 15, 2023
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
@anantjain45823 @Sanjay-Veernala
Revert "fix(INT-339): marketo response handler to handle static list …
c8b3b5a 
…removed and skipped statuses" (#2619)

Revert "fix(INT-339): marketo response handler to handle static list removed and skipped statuses (#2606)"

This reverts commit e3fed49.
@anantjain45823 anantjain45823 deleted the revert-2606-fix.marketoNestedResponseHandling branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@sanpj2292 sanpj2292 sanpj2292 approved these changes

@mihir-4116 mihir-4116 Awaiting requested review from mihir-4116 mihir-4116 is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anantjain45823 @sanpj2292 @yashasvibajpai