Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return 298 for filtered/dropped events in user transformer #2665

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

psrikanth88
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@psrikanth88 psrikanth88 force-pushed the chore.user-transfromer-298-status-code branch from 367851c to e93f227 Compare September 26, 2023 22:34
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (56c80f2) 87.01% compared to head (0c56df9) 87.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2665      +/-   ##
===========================================
+ Coverage    87.01%   87.11%   +0.09%     
===========================================
  Files          635      636       +1     
  Lines        28303    28341      +38     
  Branches      6715     6724       +9     
===========================================
+ Hits         24629    24688      +59     
+ Misses        3340     3325      -15     
+ Partials       334      328       -6     
Files Coverage Δ
src/constants/index.js 100.00% <100.00%> (ø)
src/routes/userTransform.ts 100.00% <100.00%> (ø)
src/util/common.js 52.63% <100.00%> (+5.57%) ⬆️
src/controllers/userTransform.ts 7.46% <0.00%> (ø)
src/services/userTransform.ts 57.89% <74.07%> (+46.64%) ⬆️
src/middlewares/featureFlag.ts 10.52% <10.52%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psrikanth88 psrikanth88 force-pushed the chore.user-transfromer-298-status-code branch from 05e4d0b to 6fca43d Compare October 2, 2023 18:04
chandumlg
chandumlg previously approved these changes Oct 2, 2023
Jayachand
Jayachand previously approved these changes Oct 3, 2023
@psrikanth88 psrikanth88 dismissed stale reviews from Jayachand and chandumlg via 0c56df9 October 3, 2023 18:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chandumlg chandumlg merged commit b5d28a3 into develop Oct 3, 2023
14 checks passed
@chandumlg chandumlg deleted the chore.user-transfromer-298-status-code branch October 3, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants