Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): add status code & batched value in response structure #2684

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Oct 4, 2023

Description of the change

Resolves INT-392

  • Kafka's final response wasn't containing the statusCode and batched values. This PR adds it.
  • Old response structure :
    { batchedRequest: [], metadata: [], destination: {}}
  • New Rsponse structure :
    { batchedRequest: [], metadata: [], destination: {}, statusCode: "", batched: ""}

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested review from a team as code owners October 4, 2023 10:15
@ujjwal-ab ujjwal-ab requested review from utsabc and saikumarrs October 4, 2023 10:15
@ujjwal-ab ujjwal-ab self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e37d693) 87.12% compared to head (fd2253e) 87.12%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2684   +/-   ##
========================================
  Coverage    87.12%   87.12%           
========================================
  Files          639      639           
  Lines        28408    28411    +3     
  Branches      6734     6735    +1     
========================================
+ Hits         24751    24754    +3     
  Misses        3329     3329           
  Partials       328      328           
Files Coverage Δ
src/v0/destinations/kafka/transform.js 94.44% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chandumlg
chandumlg previously approved these changes Oct 4, 2023
sanpj2292
sanpj2292 previously approved these changes Oct 5, 2023
@ujjwal-ab ujjwal-ab dismissed stale reviews from sanpj2292 and chandumlg via 556641f October 5, 2023 04:57
@sanpj2292 sanpj2292 self-requested a review October 5, 2023 09:00
sanpj2292
sanpj2292 previously approved these changes Oct 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ujjwal-ab ujjwal-ab merged commit 99f39f5 into develop Oct 5, 2023
14 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the fix.kafka.response branch January 6, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants