Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v3 api support to appsflyer #3412

Merged
merged 7 commits into from
Jun 7, 2024
Merged

feat: add v3 api support to appsflyer #3412

merged 7 commits into from
Jun 7, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented May 23, 2024

What are the changes introduced in this PR?

https://dev.appsflyer.com/hc/reference/s2s-events-api3-post

What is the related Linear task?

Resolves INT-1777

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested a review from a team as a code owner May 23, 2024 16:22
@shrouti1507 shrouti1507 self-assigned this May 23, 2024
@shrouti1507 shrouti1507 added the enhancement New feature or request label May 23, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (4dde75c) to head (c9ce77b).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3412   +/-   ##
========================================
  Coverage    88.02%   88.03%           
========================================
  Files          570      570           
  Lines        30772    30782   +10     
  Branches      7350     7358    +8     
========================================
+ Hits         27088    27098   +10     
+ Misses        3377     3349   -28     
- Partials       307      335   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai
Copy link
Member

yashasvibajpai commented May 24, 2024

  • Any potential tests to cover these?
    yes, not added yet, will add and ask for re-review

yashasvibajpai
yashasvibajpai previously approved these changes May 24, 2024
shrouti1507 and others added 3 commits May 28, 2024 20:48
* fix: onboard adjust source

* feat: onboard adjust source

* feat: small edit

* feat: small edit
Gauravudia
Gauravudia previously approved these changes Jun 7, 2024
yashasvibajpai
yashasvibajpai previously approved these changes Jun 7, 2024
utsabc
utsabc previously approved these changes Jun 7, 2024
@shrouti1507 shrouti1507 dismissed stale reviews from utsabc, yashasvibajpai, and Gauravudia via c9ce77b June 7, 2024 10:37
Copy link

sonarqubecloud bot commented Jun 7, 2024

@shrouti1507 shrouti1507 merged commit e124470 into develop Jun 7, 2024
16 checks passed
@shrouti1507 shrouti1507 deleted the enhance.af branch June 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants