fix: tiktok_v2 assigning value to undefined properties #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
reviewed
May 29, 2024
| @@ -42,6 +42,8 @@ const getTrackResponsePayload = (message, destConfig, event, setDefaultForConten | |||
| // if contents is not present but we have properties.products present which has fields with superset of contents fields | |||
| if (!payload.properties?.contents && message.properties?.products) { | |||
| // retreiving data from products only when contents is not present | |||
| // properties object may be empty due which next line may give some error | |||
| payload.properties = payload.properties ? payload.properties : {}; | |||
There was a problem hiding this comment.
payload.properties || {}
| @@ -55,6 +57,8 @@ const getTrackResponsePayload = (message, destConfig, event, setDefaultForConten | |||
| } | |||
| // setting content-type default value in case of all standard event except `page-view` | |||
| if (!payload.properties?.content_type && setDefaultForContentType) { | |||
| // properties object may be empty due which next line may give some error | |||
| payload.properties = payload.properties ? payload.properties : {}; | |||
There was a problem hiding this comment.
payload.properties || {}
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3426/test-report.html |
shrouti1507
approved these changes
May 29, 2024
koladilip
approved these changes
May 29, 2024
|
anantjain45823
added a commit
that referenced
this pull request
May 30, 2024
* fix: tiktok_v2 assigning value to undefined properties (#3426) * fix: tiktok_v2 assigning value to undefined properties * chore: address comments * chore(release): 1.68.1 * fix: bugsnag error for emarsys track call (#3428) --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com>
anantjain45823
added a commit
that referenced
this pull request
May 30, 2024
chore(release): pull hotfix-release/v1.68.1 into main (#3427) * fix: tiktok_v2 assigning value to undefined properties (#3426) * fix: tiktok_v2 assigning value to undefined properties * chore: address comments * chore(release): 1.68.1 * fix: bugsnag error for emarsys track call (#3428) --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-XXX
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.