chore: salesforce refactor

[sanpj2292]

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-1129

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

---

Developer checklist

• My code follows the style guidelines of this project

• No breaking changes are being introduced.

• All related docs linked with the PR?

• All changes manually tested?

• Any documentation changes needed with this change?

• Is the PR limited to 10 file changes?

• Is the PR limited to one linear task?

• Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

• Is the type of change in the PR title appropriate as per the changes?

• Verified that there are no credentials or confidential data exposed with the changes.

[devops-github-rudderstack]

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3824/test-report.html

[codecov]

Codecov Report

Attention: Patch coverage is 93.00699% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.48%. Comparing base (e90d2ad) to head (23e0bc8).
Report is 41 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/v0/util/salesforce/common.ts	90.90%	4 Missing ⚠️
src/v0/util/salesforce/legacy.ts	91.66%	3 Missing ⚠️
src/v0/destinations/salesforce/transform.js	60.00%	2 Missing ⚠️
src/v0/util/salesforce/oauth.ts	95.45%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3824      +/-   ##
===========================================
+ Coverage    89.05%   90.48%   +1.42%     
===========================================
  Files          618      619       +1     
  Lines        33071    32363     -708     
  Branches      7814     7682     -132     
===========================================
- Hits         29452    29284     -168     
+ Misses        3336     2855     -481     
+ Partials       283      224      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[koladilip]

we should try to conver this into typescript

[sonarqubecloud]

Quality Gate passed

Issues
19 New issues
1 Accepted issue

Measures
0 Security Hotspots
93.7% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

[devops-github-rudderstack]

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.