Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant ids and userIdentifier when gbraid or wbraid are there #3910

Merged
merged 13 commits into from
Dec 6, 2024

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Dec 2, 2024

What are the changes introduced in this PR?

We are doing the following changes:

  1. We can pass only one of gclid, wbraid and gbraid. If all three are available we are considering gclid. If both wbraid and gbraid are available without gclid we are throwing error.
  2. We don't need to pass userIdentifier if any click ids are available. But if we send userIdentifiers along with gclid then Google ads is accepting that. So we are not changing that behaviour, we just stopped throwing errors.

What is the related Linear task?

Resolves INT-2942

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested review from a team and sivashanmukh as code owners December 2, 2024 13:03
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (b3f7140) to head (9014d8a).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3910   +/-   ##
========================================
  Coverage    90.47%   90.48%           
========================================
  Files          615      615           
  Lines        32329    32352   +23     
  Branches      7682     7688    +6     
========================================
+ Hits         29250    29273   +23     
  Misses        2823     2823           
  Partials       256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

koladilip
koladilip previously approved these changes Dec 2, 2024
yashasvibajpai
yashasvibajpai previously approved these changes Dec 3, 2024
koladilip
koladilip previously approved these changes Dec 3, 2024
@ItsSudip ItsSudip dismissed stale reviews from koladilip and yashasvibajpai via 4533bd7 December 3, 2024 09:21
@ItsSudip ItsSudip merged commit 313710c into develop Dec 6, 2024
27 checks passed
@ItsSudip ItsSudip deleted the fix.gaoc branch December 6, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants