Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #698: Add rounding option for mloginfo --queries #758

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

stennie
Copy link
Collaborator

@stennie stennie commented Dec 28, 2019

No description provided.

@stennie stennie added this to the 1.6.1 milestone Dec 28, 2019
@@ -115,12 +122,12 @@ def run(self):
stats['max'] = max(group_events) if group_events else 0
stats['mean'] = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can be removed, since stats['mean'] with get set to a value or zero in line 130.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree !

Copy link
Collaborator

@kallimachos kallimachos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on a line that I think is superfluous, but otherwise LGTM.

@stennie stennie merged commit b9ad1cc into rueckstiess:develop Dec 31, 2019
bugre added a commit to bugre/mtools that referenced this pull request Jan 5, 2020
…_JSONSerialize_crash_w_bytes

* 'develop' of github.com:bugre/mtools:
  Add VSCode config to .gitignore
  Bump dev version
  Update for 1.6.1 release
  Fix Flake8 complaints
  Fix rueckstiess#765: mloginfo --clients: more robust parsing of client metadata (rueckstiess#766)
  Fix rueckstiess#761: mtools should use python3 in shebangs
  Fix rueckstiess#698: Add rounding option for mloginfo --queries (rueckstiess#758)
  More specific match for checkpoint duration log line
  Fix rueckstiess#258: Add timezone to mloginfo summary
@stennie stennie deleted the issue-698 branch October 29, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants