extension: Make Options extend BaseLoadOptions
#10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omit config values from `DEFAULT_OPTIONS`, which are already part of `DEFAULT_CONFIG` in `ruffle-core`. Also use spread syntax to avoid naming each config that should pass to `ruffle-core`.
relrelb
force-pushed
the
extension_options
branch
from
8205060 to
e016409
Compare
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit config values from
DEFAULT_OPTIONS, which are already part ofDEFAULT_CONFIGinruffle-core. Also use spread syntax to avoid naming each config that should pass toruffle-core.