ci: Split cargo-deny into its own job, add cargo-machete #15774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
changed the title
torokati44
force-pushed
the
cargo-udeps
branch
5 times, most recently
from
21559e2 to
b4e8c50
Compare
|
Turns out, machete only needed two ignores, for fairly reasonable ... reasons. |
torokati44
force-pushed
the
cargo-udeps
branch
2 times, most recently
from
8068320 to
e9e2658
Compare
|
Well it didn't turn out that bad IMHO... :) |
torokati44
force-pushed
the
cargo-udeps
branch
2 times, most recently
from
f80a7f6 to
e72265b
Compare
Dinnerbone
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the source branch name, I went with
cargo-macheteinstead ofcargo-udeps: https://blog.benj.me/2022/04/27/cargo-machete/Unfortunately, both point to a couple false positives, so they would need some manual handholding, polluting our
Cargo.tomlfiles. ( bnjbvr/cargo-machete#118 )Do we even need this...? :/