Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "github: Add a Dependabot group just for bumping Cargo.lock" #16344

Merged
merged 1 commit into from
May 16, 2024

Conversation

danielhjacobs
Copy link
Contributor

@danielhjacobs danielhjacobs commented May 16, 2024

This reverts commit 6c144a0.

See https://github.com/ruffle-rs/ruffle/runs/25067106580. The only options for the dependency-type of a group are production and development: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups. This was done with the options for allow in mind: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow.

As for update-types, that should have been:

        update-types:
          - "major"
          - "minor"
          - "patch"

@torokati44
Copy link
Member

torokati44 commented May 16, 2024

~ This was done with the options for allow in mind: docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow.

Isn't it possible to set it there instead, then?

@danielhjacobs
Copy link
Contributor Author

Isn't it possible to set it there instead, then?

Probably, I just didn't know the right syntax to use to properly fix this. If you want to fix this instead, I'll close this PR.

@torokati44
Copy link
Member

Seems like what I wanted is not supported... dependabot/dependabot-core#1778
Too bad... :( Sorry for the spam, should have been more thorough with this.

@torokati44 torokati44 force-pushed the quick-revert-16335 branch from 67c8dca to 0e0ed3c Compare May 16, 2024 21:17
@Dinnerbone Dinnerbone merged commit 8f67d40 into ruffle-rs:master May 16, 2024
17 checks passed
@danielhjacobs danielhjacobs deleted the quick-revert-16335 branch May 16, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants