extension: Re-enable SWF takeover using declarativeNetRequest

[danielhjacobs]

This is based on w3c/webextensions#460. I added feature detection. This should be tested on Chrome Beta or above.

See screencast:

Screencast.from.2024-06-28.09-56-35.webm

[evilpie]

Can we at least wait until this is properly supported in Chrome so we don't have to do that annoying bug detection dance?

[danielhjacobs]

Can we at least wait until this is properly supported in Chrome so we don't have to do that annoying bug detection dance?

I don't disagree with waiting but we'll still need to decide what to do here. Supposedly Chromium does throw just like Firefox with a fully unsupported RuleCondition. The bug, as confirmed in https://issues.chromium.org/issues/347186592#comment9, is actually that features developed behind a flag are not fully hidden behind the flag in Chrome. Without this "annoying bug detection dance", with just a try and catch, we may end up in a situation where both older and newer versions of Chrome work properly with Ruffle but the versions that were implementing this feature behind a flag are broken. I'm not sure that's acceptable.

[evilpie]

the versions that were implementing this feature behind a flag are broken. I'm not sure that's acceptable.

I didn't quite realize this could happen. I sort of assumed this problem would still be limited to Canary.

Do we want/need to have a setting for disabling this specific feature?

[danielhjacobs]

Having a setting for disabling this feature may be nice in general since some people did find it frustrating when trying to just download SWFs. I added showSWFDownload to the player page for that reason.

However, I'm not sure that's enough. Try checking out ca7fc87 and using the extension in Chrome stable. https://google.com redirects to the player page. Needing to disable this feature to stop that is unintuitive.

[danielhjacobs]

Official docs: https://developer.chrome.com/docs/extensions/reference/api/declarativeNetRequest#type-HeaderInfo and https://developer.chrome.com/docs/extensions/reference/api/declarativeNetRequest#property-RuleCondition-excludedResponseHeaders and https://developer.chrome.com/docs/extensions/reference/api/declarativeNetRequest#property-RuleCondition-responseHeaders

[Dinnerbone]

Thank you!