tests: Rebuild AAC decoding test without network permission to make it work in FP #19022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
added
A-tests
kjarosh
approved these changes
Dec 20, 2024
|
Just curious: how did you make sure it works in FP with network enabled? 🤔 |
|
The SWF was probably built with Flash first, when I made the original test, then later I made some minor cleanups (like comments, formatting, output format, or increased tolerances), and rebuilt it with MXMLC. I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add the
-use-network=falseargument to MXMLC, so that Flash Player allows the SWF to access the local FLV files.Ruffle doesn't care about this yet, so the test was technically passing.