avm1: Do not panic when swapping children on depth/render list desync #19594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm1
core/src/display_object/container.rs
Outdated
| .unwrap(); | ||
| self.render_list_mut().insert(new_position + 1, child); | ||
| .map(|pos| pos + 1) | ||
| .unwrap_or(0); |
There was a problem hiding this comment.
Would it be better for this to log an error instead of inserting it at position 0 if the DO wasn't in the render list?
There was a problem hiding this comment.
Added an error, although it won't tell us much, only that a desync happened and we should expect depth list and render list to not be in sync. We would have to add debug checks during mutation to get useful errors or panics.
I'll also be trying to refactor this in the future so that the desync is less likely / impossible to happen.
Unfortunately sometimes the render list and the depth list become desynchronized. When swapping children this caused panics. I haven't been able to reproduce those scenarios, but it's better to leave the render/depth list messed up than to panic in this case.
kjarosh
force-pushed
the
swap-at-depth-crash
branch
from
0c6d535 to
69b96c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately sometimes the render list and the depth list become desynchronized. When swapping children this caused panics.
I haven't been able to reproduce those scenarios, but it's better to leave the render/depth list messed up than to panic in this case.