core: update gc-arena to latest master
#19853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-core
moulins
force-pushed
the
gc-arena-next
branch
2 times, most recently
from
a67f904 to
95238e6
Compare
adrian17
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
Collect::traceis now generic over the tracing context: this makes theCollectCellabstraction used in the string interner unsound (asCollect::tracecan now be, in principle, called at any time). As such, this is replaced by a simplerRefCell.gc-arenaupgraded itshashbrowndependency to0.15, but we need to stay on0.14because we useRawTable(in the AVM2DynamicMapand in the string interner). The work-around is to manually implementCollecton these types.gc-arenaimproved its pacing algorithm; there are no API changes, but we should investigate the performance impact before merging.