core: Don't propagate error when decoding malformed PNG data (fixes #18831) #19863
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a transparent bitmap with the same dimensions instead (fixes ruffle-rs#18831)
ninjamuffin99
force-pushed
the
fix-18831
branch
from
94b0c38 to
020c776
Compare
Lord-McSweeney
added
A-rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit unconfirmed fully, but my theory on #18831 is that Stencyl used to create malformed PNG data when generating BitmapFont images (relavant issue from Stencyl forums, and (3.4.0 (Beta 1) Build 8734 - October 10, 2015) mentions "Fix: Bitmap Font image importing")
This PR fixes the panic by handling the DecodingError and creating a transparent bitmap with the same dimensions as the source instead. This behavior I based off of HaxeFlixel / OpenFL, which does the same. Stencyl is based off much older versions of OpenFL / NME fwiw