core: Use player notifications for virtual keyboard #19889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor replaces open_virtual_keyboard/close_virtual_keyboard methods from UiBackend with OpenVirtualKeyboard/CloseVirtualKeybard player notifications.
kjarosh
added
A-core
|
@torokati44 is this refactor okay for Android? |
evilpie
reviewed
Mar 22, 2025
| @@ -208,15 +209,17 @@ impl<'gc> FocusTracker<'gc> { | |||
| } | |||
|
|
|||
| fn update_virtual_keyboard(&self, context: &mut UpdateContext<'gc>) { | |||
| if let Some(text_field) = self.get_as_edit_text() { | |||
| let notification = if let Some(text_field) = self.get_as_edit_text() { | |||
There was a problem hiding this comment.
Suggested change
| let notification = if let Some(text_field) = self.get_as_edit_text() { | |
| let notification = self.get_as_edit_text().is_some_and(|tf| tf.is_editable()) |
|
Has anyone tested this on iOS? I'd be happy to do so if someone puts up a demo build |
Oh dang, I forgot about iOS. It won't work there because notifications are asynchronous and it requires focus to be set synchronously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor replaces
open_virtual_keyboard/close_virtual_keyboard methodsfromUiBackendwithOpenVirtualKeyboard/CloseVirtualKeybardplayer notifications.It's a follow up to #19666 and a PoC of how notifications can be used for other purposes too.