avm2: Port Object and Class to AS #20049
Open
+527
−980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-method-unification
branch
2 times, most recently
from
e6ae68f to
05d8683
Compare
Lord-McSweeney
force-pushed
the
avm2-method-unification
branch
2 times, most recently
from
664c3e7 to
1c1c117
Compare
Lord-McSweeney
force-pushed
the
avm2-method-unification
branch
from
1c1c117 to
73a672d
Compare
added 7 commits
April 14, 2025 18:31
Also hint that Script::globals should be inlined and make Script.translation_unit non-Option
Lord-McSweeney
force-pushed
the
avm2-method-unification
branch
from
73a672d to
169847b
Compare
danielhjacobs
added
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17494
These are the last two classes that were written in Rust. After this PR, we should easily be able to merge NativeMethod and BytecodeMethod into one struct, since all methods now have ABC info.