chore: Fix nightly clippy lint: clippy::if_then_panic

[torokati44]

Also note the // XXX comment about a potential typo / copy-paste error found by accident.

[torokati44]

What do you think about the typo note, @adrian17? Should that be fixed or left as is?

[torokati44]

Huh, my own local nightly clippy doesn't complain about these bunch of instances caught by CI. I just updated it... Weird.

[danielhjacobs]

The == asserts could be changed to assert_eq! (See also rust-lang/rust-clippy#7716)

[torokati44]

Yep, you are right, fixed!

[danielhjacobs]

Darn, issue in a dependent crate: https://github.com/brendanzab/approx/blob/master/src/macros.rs#L83

[torokati44]

Yep, almost done with the PR for that... :)

[torokati44]

There: brendanzab/approx#72

[torokati44]

So, best case scenario now: The PR is accepted soon, a new version of approx is released not much later, dependabot picks it up and bumps it, so the remaining warning goes away on its own, all before the lint makes it into stable clippy.
The rest of the fixes here can go in until then, I think.
That potential typo/copypasta error might be worth a separate PR, just so behavior is not changed here.

[relrelb]

There: brendanzab/approx#72

Assuming it will take time for the PR to be merged (and a new approx version to be released), for now we can add #[allow(clippy::if_then_panic)] where needed in core/src/matrix.rs, and place TODOs referring to that PR.

[torokati44]

Thanks for the review @relrelb, I have applied your suggestions.

[relrelb]

Thanks, LGTM! Will merge once CI passes.

[relrelb]

Looks like the nightly Rust compiler is broken, as it emits hundreds of errors now. Will merge anyway when the required workflows finish.

[torokati44]

Yeah, saw the same thing on my machine too, will probably be fixed in a day or two.
Alright!