avm1: Introduce TextFormatObject
#5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrelb
force-pushed
the
avm1_text_format
branch
2 times, most recently
from
c51934d
to
aae94da
Compare
`TextFormat` objects differ from regular objects in that `TextField.setTextFormat` and `TextField.setNewTextFormat` accept only the former, and ignore the latter. Also, `TextFormat.prototype` has native accessors that coerce the values on get/set.
relrelb
force-pushed
the
avm1_text_format
branch
from
aae94da
to
36b1a0a
Compare
Since `TextFormat.color` should preserve the alpha value, and the AVM1 getter/setter no longer reset it, we need to reset it in other places: * `TextField.textColor` setter. * `EditText` SWF tag handling. * HTML parsing. And to set it explicitly to 255 in `LayoutBox::as_renderable_text`.
relrelb
force-pushed
the
avm1_text_format
branch
from
36b1a0a
to
57f80a9
Compare
kmeisthax
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextFormatobjects differ from regular objects in thatTextField.setTextFormatandTextField.setNewTextFormatacceptonly the former, and ignore the latter.
Also,
TextFormat.prototypehas native accessors that coerce thevalues on get/set.