Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging #6

Closed
wants to merge 2 commits into from
Closed

Fix logging #6

wants to merge 2 commits into from

Conversation

RolandBERTINJOHANNET
Copy link
Contributor

batch functions were moved to utils but the logging code wasn't updated so no one can train a gw.

I changed the code to use the new locations. It runs fine locally but the pytest is unable to import shimmer.modules.utils I have no idea why

@bdvllrs
Copy link
Collaborator

bdvllrs commented Mar 25, 2024

This is only true if you use the last version of shimmer. But as it stands, the version in poetry.lock has not the batch_functions updated to the utils.

If you want to add this, we also need to update shimmer's dependency in poetry.

Most likely this only breaks your setup because you use shimmer inside this repo that you update independently from this one. Someone using poetry normally would not have the issue.

Also I'm closing because I was also working on it in the update_shimmer branch (which also contains the dependency updates).

@bdvllrs bdvllrs closed this Mar 25, 2024
@RolandBERTINJOHANNET
Copy link
Contributor Author

ok

@bdvllrs bdvllrs deleted the fix_logging branch July 31, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants