Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust characters used in passphrases #453

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Conversation

FokkeDijkstra
Copy link
Member

The ; in passwords can break command-line usage, like for example in the pulp playbooks.

@FokkeDijkstra
Copy link
Member Author

There may be more characters that could give issues in some cases, as more of these characters have a meaning in bash.
I personally ran into the ; and a - sign.

@pneerincx
Copy link
Contributor

Hi Fokke, indeed many of these characters will cause problems in terminal ... if the password values were not properly quoted. If the quoting is our playbooks, I'd rather like to fix that. Some of the code is in dependencies though for example from Ansible Galaxy and in that case trying to get it fixed may take too much time. Can you recall which tasks failed with ; or - in the passwords?

@FokkeDijkstra
Copy link
Member Author

The issue was with the pulp playbooks from Ansible Galaxy. It can be easily fixed on their side, but on the other hand there are still plenty characters left for the passphrase, so removing these two won't affect the passphrase security.

@pneerincx pneerincx merged commit a55451b into develop Aug 31, 2021
@pneerincx pneerincx deleted the fix/generate_secrets branch August 31, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants