You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user on AMO correctly noticed the extension always injects a class called mastodon-simplified-federation-injected onto the body of each website – even non-Mastodon websites.
Steps to reproduce
Install extension.
Go to any website.
Look in the developer tools for .mastodon-simplified-federation-injected.
Actual behavior
mastodon-simplified-federation-injected is injected on body.
Expected behavior
This injection should at most only happen on Mastodon instances, or not at all.
It can disturb users (actually the user in question noticed this as a red flag about the extension, which arguably, it can be).
System
Browser and version: Firefox 108
Add-on version: 2.0
Bug description
A user on AMO correctly noticed the extension always injects a class called
mastodon-simplified-federation-injected
onto the body of each website – even non-Mastodon websites.Steps to reproduce
.mastodon-simplified-federation-injected
.Actual behavior
mastodon-simplified-federation-injected
is injected onbody
.Expected behavior
This injection should at most only happen on Mastodon instances, or not at all.
It can disturb users (actually the user in question noticed this as a red flag about the extension, which arguably, it can be).
System
Browser and version: Firefox 108
Add-on version: 2.0
Possible solution
The code that causes this is here:
mastodon-simplified-federation/src/content_script/mastodonInject.js
Lines 150 to 157 in 5e014f3
As you can see, it is a simple guard to prevent the extension from running twice. It has been introduced in #84.
Maybe a solution could be to use a variable instead that is defined and if already defined not re-defined? To prevent a double-injection?
/cc @hueyy
The text was updated successfully, but these errors were encountered: