-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inject content script to handle interactions from remote v4 Mastodon instances #84
Conversation
…tionality on v4 Mastodon instances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again thanks a lot and here some mostly code style-related comments.
BTW you marked this as WIP, what is still missing here?
Oh merged, but @hueyy sorry testing it I noticed some bugs/things:
So unfortunately, I cannot release it as it is. |
@rugk yes, my bad, I accounted for the detailed status page in the inject function but not in the MutationObserver. Will send in a PR to fix this. I think that should resolve (1) and (2). I can't seem to reproduce (3), even on https://mastodon.social/@drewtoothpaste/109393612157338955. It sounds very odd because yes, the URL looks right. |
To be merged only after #82 is merged.
Resolves #77