Misskey support #104
Merged
Misskey support #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes rugk#63
rugk
requested changes
Mar 19, 2023
| * from which this was adapted | ||
| * @returns {Promise} | ||
| */ | ||
| function waitForElement(selector, multiple = false, timeoutDuration = 200000) { |
There was a problem hiding this comment.
Hmm did not we have a very similar code in the Mastodon injection code? Maybe we can generalize/have that in some common.js or so for all injection scripts?
| const replyButtons = await waitForElement(SELECTOR, true); | ||
| replyButtons.forEach((button) => { | ||
| try { | ||
| if (!button.classList.contains(INJECTED_REPLY_CLASS)) { |
There was a problem hiding this comment.
maybe rewrite it as an early return pattern to prevent that huge indentation… (the try blocks are already needed, so…)
Co-authored-by: rugk <rugk+git@posteo.de>
rugk
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63. There's no follow button, so only status interaction is implemented.
Known issue: it still triggers Misskey's login popup even if I do
event.stopImmediatePropagation()... I'm not sure there is an easy fix.