Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent redirection in popup and use main tab #46

Merged
merged 9 commits into from
Oct 15, 2019

Conversation

rugk
Copy link
Owner

@rugk rugk commented Oct 15, 2019

Fixes #44

grafik

@rugk rugk mentioned this pull request Oct 15, 2019
@rugk rugk merged commit 4003df7 into master Oct 15, 2019
@Malsasa
Copy link

Malsasa commented Oct 16, 2019

Wow, this is amazing change, I instantly tested it and it works (but with some commentaries).

Steps to install

I tested the extension in its latest version with link you gave:

  • I upgraded my Firefox to 69
  • I open about:debugging
  • I open manifest.json from within my cloned extension's src/ directory
  • extension installed
  • I open Ctrl+Shift+A aka addon management page
  • I check the option "Prevent popup usage"
  • I accept the question appears with "Yes"

Testing result

Following:

  • I click follow at user on different instance,
  • no additional window opened
  • current page refreshed/redirected to page with "FOLLOW" button
  • I click "FOLLOW" button
  • refreshed, no additional window opened
  • current page says "Success! You are now following:"
  • the intended user followed successfully
  • I go back to previous page to go out from "SUCCESS" page

Liking:

  • I click like button
  • refreshed, no additional page opened
  • current page changed to Notification page at my profile
  • the intended like is not performed at this point
  • I click like button once again
  • the intended post liked successfully
  • I go back to previous page to go out from Notification page

Others:
Not too difference to above.

Commentaries

It managed to remove unnecessary window, really nice! But I think it's still incomplete, as it still doesn't remove unnecessary page. I wish it skips that too so the follow, like, boost, or comment is only one time click and not two times anymore.

Thank you @rugk you made really huge changes (20 files etc.) and I love that.

@rugk
Copy link
Owner Author

rugk commented Oct 16, 2019

as it still doesn't remove unnecessary page. I wish it skips that too so the follow, like, boost, or comment is only one time click and not two times anymore.

For security reasons, I cannot really implement it, so it will always require a user interaction on your site/instance, because otherwise websites could trigger this add-on dynamically (it only detects the web request) and thus making you follow, fav or boost anything they want. 😄

Anyway, feel free to open a new issue for that, maybe in he future this problem can be solved. 😃

@rugk rugk deleted the popupPrevent branch October 16, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single Window Interactions
2 participants