-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to prevent redirection in popup and use main tab #46
Conversation
for some reason, this throws exceptions
Because this is needed for this new feature.
So no error is thrown and they still work. Note this should not change the behaviour for them, as there were no popups.
Because otherwise navigating back would be quite useful. :)
Wow, this is amazing change, I instantly tested it and it works (but with some commentaries). Steps to installI tested the extension in its latest version with link you gave:
Testing resultFollowing:
Liking:
Others: CommentariesIt managed to remove unnecessary window, really nice! But I think it's still incomplete, as it still doesn't remove unnecessary page. I wish it skips that too so the follow, like, boost, or comment is only one time click and not two times anymore. Thank you @rugk you made really huge changes (20 files etc.) and I love that. |
For security reasons, I cannot really implement it, so it will always require a user interaction on your site/instance, because otherwise websites could trigger this add-on dynamically (it only detects the web request) and thus making you follow, fav or boost anything they want. 😄 Anyway, feel free to open a new issue for that, maybe in he future this problem can be solved. 😃 |
Fixes #44