Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated translations for 'fr': French (français, langue française) #85

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Updated translations for 'fr': French (français, langue française) #85

merged 4 commits into from
Nov 23, 2022

Conversation

AntoninDelFabbro
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.
dougbu Doug Bunting

Verified

This commit was signed with the committer’s verified signature.
dougbu Doug Bunting
 Updated translations for 'fr': French (français, langue française)
@rugk
Copy link
Owner

rugk commented Nov 22, 2022

Hi @AntoninCurtit,
thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

To honor your work, you should be credited in the extension. To do that, you need to provide your name and a link in the extension.

You can credit yourself in the translation file and provide a link (in translatorLink) and a name (in translatorUsername). Also, you should add yourself to the CONTRIBUTORS.md file and the changelog as a translator to give credits here.

See https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#translations for how these placeholders are translated, especially the official doc.

Also notice there are more things to translate like the add-on listings on AMO (addons.mozilla.org) etc. See the contributing guide for more information.

Finally, please subscribe to #40 to get notified for new updates on translations etc. 😃

@rugk
Copy link
Owner

rugk commented Nov 22, 2022

Requesting a potential review from @PoorPocketsMcNeuHold and @le-jun. Unless there are objections, this will be merged soon.

@AntoninDelFabbro
Copy link
Contributor Author

Hey @rugk !
You're welcome, thanks to you for your work ! 😗

Yeah, I saw I could be credited... But, nah, it's not my cup of tea to be, it's good enough like this. 😉

Good, I may take a look a this ! Thank you for sharing all of this with me !
You're right, another opinion is still better.

Good night for now !

Verified

This commit was signed with the committer’s verified signature.
dougbu Doug Bunting
@le-jun
Copy link
Contributor

le-jun commented Nov 23, 2022

I mean… I’m ashamed to have overlooked those mistakes. Looks good to me.

@AntoninDelFabbro
Copy link
Contributor Author

✅ My job here is finished !

@le-jun 😉

@rugk rugk merged commit 3d508f4 into rugk:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants