Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pleroma support #99

Merged
merged 4 commits into from
Mar 12, 2023
Merged

Improve Pleroma support #99

merged 4 commits into from
Mar 12, 2023

Conversation

austinhuang0131
Copy link
Contributor

@austinhuang0131 austinhuang0131 commented Feb 27, 2023

  • Interacting with status (using the favourite/announce buttons). Note that the Testing guide in the wiki needs to be updated too.
  • Username detection using request body.

Feel free to only merge one commit. I'll add contributor credit after your approval.

Yes, I'm aware that I'm PR'ing from the master branch, but GitHub has a "fetch origin" button online now, so it's all good

@rugk
Copy link
Owner

rugk commented Mar 8, 2023

Hi @austinhuang0131,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

So yeah, this looks like a good improvement (though I have not tested it in practice.)

About the master branch: Yeah, sure feel free to do what you want. The only reason I always suggest a separate branch is so that you can have separate PRs. If you now e.g. would want to create a separate PR or this one would not be accepted/you'd close this, you would have all these commits in the main branch of your fork, which is unfortunate, as you would have to rewrite the history in a quite cumbersome way to get it right and start with a "fresh" branch from upstream. I know, yeah, there are other solutions, but for beginners I always suggest this to keep it clean and in shape.

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor thing.

src/background/modules/Detect/Pleroma.js Outdated Show resolved Hide resolved
@austinhuang0131 austinhuang0131 requested a review from rugk March 9, 2023 00:04
@rugk rugk merged commit 0f53bff into rugk:master Mar 12, 2023
@austinhuang0131 austinhuang0131 deleted the master branch March 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants