shift err messags to localized form

rugk · Mar 10, 2019 · 26e2503 · 26e2503
1 parent 6a5ec8c
commit 26e2503
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json
@@ -80,6 +80,10 @@
  "message": "Permission request failed.",
  "description": "Error shown when a permission request failed. This indicates a technical error and does NOT mean the user declined the permission."
  },
+ "errorQrCodeOverflow": {
+ "message": "Cannot generate QR Code, data size too big.",
+ "description": "Error shown when QR code cannot be generated due to overflow in input size."
+ },
  "requestDownloadPermissionForQr": {
  "message": "To continue to save the QR code, we need the download permission.",
  "description": "Shown, when the user is asked to allow the download permission to save the QR code."

diff --git a/src/popup/modules/UserInterface.js b/src/popup/modules/UserInterface.js
@@ -113,8 +113,9 @@ const refreshQrCode = throttle(() => {
  QrCreator.setTextInternal(text);
  QrCreator.generate();
  } catch (e) {
+ // Error thrown from qrcodegen & kjua wrapper when code too long
  if (e === "Data too long") {
- CommonMessages.showError("Cannot generate Qr Code, data size too big.");
+ CommonMessages.showError("errorQrCodeOverflow", true);
  Logger.logError("Data exceeds maximum size:", text.length);
  } else {
  throw e;