-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning for inverted QR codes (when background color is dark and foreground light) #20
Comments
I have separated the luminance calculation into it's own function in the gist I posted in the other issue. |
Great, but did you see that @ENT8R already created an own PR, which includes the contrast (and thus, as it seems luminance) calculation: https://github.com/rugk/offline-qr-code/pull/86/files#diff-91ba5f4df12e1b6b0629662164b3f14eR245? But as for this issue (i.e. "finding out which color is dark/light") I don't think we need a new function for that luminance thing. Could not the contrast ratio calculation just return |
You could replace |
Sounds good… |
BTW, @LMLB, – I know, I am a bit late –, but if you wanna do a PR, feel free to do so. But I've got some other color issues in this repo, too. 😄 |
I am assuming you will do no PR, @LMLB. |
Similar to #19 there should be warning. But this time, it should just say that you can only scan such inverted Qr codes with some QR code readers (e.g. Android "Barcode reader" with a special option).
Maybe also create a wiki page (or FAQ?), for such a thing and explain how to scan it.
Depends on #19
The text was updated successfully, but these errors were encountered: