Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate screenhots and screencasts in new Firefox design #268

Closed
rugk opened this issue Aug 16, 2021 · 16 comments · Fixed by #291
Closed

Recreate screenhots and screencasts in new Firefox design #268

rugk opened this issue Aug 16, 2021 · 16 comments · Fixed by #291
Assignees
Labels
documentation Code or textual documentation/text-only work good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com

Comments

@rugk
Copy link
Owner

rugk commented Aug 16, 2021

The screenshots still follow the old Photon (tab) design, which of course does not

The new design with floating tabs looks very much different. So all images and screencasts need to be re-made.

If anyone wants to contribute, this is a very easy task! You see all files in the assets/screencasts and assets/screenshots directories. You just need to look at them and do/screenshot (exactly) the same in a new modern Firefox (stable or even Firefox Developer Edition is enough), replace all files and create and submit a Pull Request.

Also mind to keep the pixel sizes (width/height) of the GIFs/images approximately the same, as they were optimized for the display on addons.mozilla.org (AMO) etc.

@rugk rugk added good first issue Good for newcomers documentation Code or textual documentation/text-only work labels Aug 16, 2021
@dialectrical
Copy link

Sounds pretty straightforward! I can tackle it if you want to go ahead and assign me. I can knock it out some time today or tomorrow.

@rugk
Copy link
Owner Author

rugk commented Aug 26, 2021

Thanks a lot for taking this on! 😃 Feel free to send a PR if you've done it.

@dialectrical
Copy link

dialectrical commented Aug 27, 2021

Thanks!

How exact did you want the new screenshots to match the old ones @rugk? I can get the dimensions to match easily but do you also want the exact same Firefox themeing, etc.?

@rugk
Copy link
Owner Author

rugk commented Aug 27, 2021

It does not have to be exactly the same (pixel size), but the same general theme e.g. would be quite nice.
The OS does not matter.

@dialectrical
Copy link

A little busier IRL than I thought I'd be, sorry!

The English screenshots are done, just need to do the screencasts and screenshot the German settings.

@rugk
Copy link
Owner Author

rugk commented Aug 28, 2021

Oh sure, thanks a lot! Did not even remember I screenshott'ed the German settings separately, that is nice.

@dialectrical
Copy link

Alright, sorry for the delay!

Pull request #271 has the new screenshots and screencaps.

@rugk rugk linked a pull request Sep 3, 2021 that will close this issue
@rugk
Copy link
Owner Author

rugk commented Sep 3, 2021

Thanks a lot, no problem. Take the time you need. 🙂

@Tch4lla
Copy link
Contributor

Tch4lla commented Sep 17, 2022

Hi there. Is this task still available? I would like to offer my assistance if possible

@rugk
Copy link
Owner Author

rugk commented Sep 17, 2022

Sure it is, so I assign it to you @Tch4lla then. 🙂

Thanks for your work already. 🙂

@rugk rugk assigned Tch4lla and unassigned dialectrical Sep 17, 2022
@rugk rugk added the hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com label Sep 17, 2022
@RohitRajvaidya5
Copy link

Is this issue resolved? I want to contribute in it.

@Tch4lla
Copy link
Contributor

Tch4lla commented Sep 19, 2022

I have already submitted my pull request for this issue, and am currently waiting on confirmation if there are any changes or tweaks that need to be made.

@rugk rugk linked a pull request Oct 19, 2022 that will close this issue
@rugk
Copy link
Owner Author

rugk commented Oct 19, 2022

Indeed, #284 is the PR to fix these, Sorry for the delay, I was busy and missed the notifications.

I assume, if help is needed, @RohitRajvaidya5 you can jump in and help here. Feel free to test or review the existing PR, BTW.

@Tch4lla
Copy link
Contributor

Tch4lla commented Oct 24, 2022 via email

@Tch4lla
Copy link
Contributor

Tch4lla commented Oct 30, 2022

I have made those adjustments and have submitted and updated pull request. I hope that it is not too much work to merge

@rugk rugk linked a pull request Oct 22, 2024 that will close this issue
@rugk
Copy link
Owner Author

rugk commented Oct 22, 2024

Fixed by #291

(Missed linking that issue, sorry.)

@Tch4lla FYI, next time, you can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body.

@rugk rugk closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Code or textual documentation/text-only work good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com
Projects
None yet
4 participants