Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context-menu item for generating a QR code for _the current page_ #321

Closed
benlk opened this issue Jun 10, 2024 · 9 comments · Fixed by #336
Closed

Add context-menu item for generating a QR code for _the current page_ #321

benlk opened this issue Jun 10, 2024 · 9 comments · Fixed by #336
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@benlk
Copy link

benlk commented Jun 10, 2024

Background

This request is to add feature parity between Firefox with this addon, and with Chrome. Chrome's current QR code implementation adds a "Create QR code for this page" menu item to the right-click menu.

Proposed solution

When the user right-clicks or invokes the context menu not on a selection and not on a link, this extension's addition to the context menu should show an entry to generate a QR code for the current page, as if the user had clicked on the extension's menu button.

Alternatives

Additional context

@benlk benlk added the enhancement New feature or request label Jun 10, 2024
@rugk
Copy link
Owner

rugk commented Jun 10, 2024

This sounds like a legitimate feature request, but it should be optional (maybe opt-in, i.e. disabled by default?) as in #157 many people already want to not want that, after all…

But I agree feature parity is a good argument.

Should also be an easy thing to implement, so I'll mark it as a good first issue.

@rugk rugk added the good first issue Good for newcomers label Jun 10, 2024
@amiii123malviya
Copy link

Hello,

Is this issue still active?
I would like to work on this.

Best Regards.

@rugk
Copy link
Owner

rugk commented Aug 2, 2024

It's not done yet. So yeah, you can work on it, just consider what I've said before, i.e. make it configurable etc.

@PKBAJPAI12
Copy link

Hi,
This issue is still open to work?
I want to work on this issue

Thanks

@rugk
Copy link
Owner

rugk commented Aug 14, 2024

I have not seen any activity by @amiii123malviya for two weeks, so I am assigning it to you @PKBAJPAI12. Feel free to take it on!

@ffllyygod
Copy link

Hello rugk,
I hope you have been doing well. I want to contribute to this feature, so please let me know if this issue is occupied or if I can start working on it.
Thanks,
-ffllyygod

@rugk rugk assigned ffllyygod and unassigned amiii123malviya Sep 10, 2024
@rugk
Copy link
Owner

rugk commented Sep 10, 2024

Sure, as I had no activity, go ahead!

@mahmoudhusam
Copy link
Contributor

Hi @rugk, I’d like to work on this issue. I see it’s marked as a good first issue, and I believe it would be a great starting point for me. Could you assign it to me?
Thank you!

@rugk rugk assigned mahmoudhusam and unassigned ffllyygod Oct 10, 2024
@rugk
Copy link
Owner

rugk commented Oct 10, 2024

Sure, go ahead!

mahmoudhusam added a commit to mahmoudhusam/offline-qr-code that referenced this issue Oct 14, 2024
mahmoudhusam added a commit to mahmoudhusam/offline-qr-code that referenced this issue Oct 20, 2024
rugk added a commit that referenced this issue Oct 24, 2024
Add context-menu item for generating QR code for the current page (#321)
@rugk rugk closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
6 participants