-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context-menu item for generating a QR code for _the current page_ #321
Comments
This sounds like a legitimate feature request, but it should be optional (maybe opt-in, i.e. disabled by default?) as in #157 many people already want to not want that, after all… But I agree feature parity is a good argument. Should also be an easy thing to implement, so I'll mark it as a good first issue. |
Hello, Is this issue still active? Best Regards. |
It's not done yet. So yeah, you can work on it, just consider what I've said before, i.e. make it configurable etc. |
Hi, Thanks |
I have not seen any activity by @amiii123malviya for two weeks, so I am assigning it to you @PKBAJPAI12. Feel free to take it on! |
Hello rugk, |
Sure, as I had no activity, go ahead! |
Hi @rugk, I’d like to work on this issue. I see it’s marked as a good first issue, and I believe it would be a great starting point for me. Could you assign it to me? |
Sure, go ahead! |
Add context-menu item for generating QR code for the current page (#321)
Background
This request is to add feature parity between Firefox with this addon, and with Chrome. Chrome's current QR code implementation adds a "Create QR code for this page" menu item to the right-click menu.
Proposed solution
When the user right-clicks or invokes the context menu not on a selection and not on a link, this extension's addition to the context menu should show an entry to generate a QR code for the current page, as if the user had clicked on the extension's menu button.
Alternatives
Additional context
The text was updated successfully, but these errors were encountered: