-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 173 - Credit translator #183
Conversation
Thanks. I've changed the styling a little and fixed some issues in the Localizer lib. Also added the English example and adjusted the text/i18n selectors. BTW, also written the corresponding doc for this at https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#translator-credit-inside-of-add-on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So still TODO:
- translate the German text and test it (/me will do)
- adjust French text/translation and test it (@nicolas-trouin)
BTW to (automatically) let issues close when a PR is merged, write "fixes" before the issue number (in your heading here). |
BTW, after this is merged, and if you also want to do the same PR for the other add-ons (backlinks above this comment), then feel free to do so… 😄 |
I'll check it out ^^' |
Likely you just need to run (Because that did not happen in my case.) |
Yep that solved the problem. Anything else I can do about the french translation or other ? |
I don't know whether it's still the case, but there likely should not be a space before the |
Well, I think you'd be right for English or German, but in French there has to be a single space before and after "!", "?", ";", and maybe others too. |
Should work/hopefully be okay. /cc @nicolas-trouin
BTW, let me know in rugk/awesome-emoji-picker#18 and rugk/mastodon-simplified-federation#25 if you want to solve that. 😄 |
Fixes Issue #173
Well this seems to work.
I am sure there are still many improvements to do, so if there's something I can do, let me know 😉
Example with browser configured in french :
Example with browser configured in german, where the english text is shown :