Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first try to resolve issue #157 #257

Closed
wants to merge 2 commits into from
Closed

first try to resolve issue #157 #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bc837c
add checkbox
schmelto Sep 9, 2020
373b8a1
change postion + add default check
schmelto Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/options/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,13 @@ <h1 data-i18n="__MSG_titleAddonBehavior__">Addon behavior</h1>
<span data-i18n="__MSG_optionDebugModeDescr__" class="helper-text">This is only useful to get more detailed logging output in the console for reporting bugs, etc.</span>
</div>
</li>

<li>
<div class="line">
<input class="setting save-on-change" type="checkbox" id="popupShowContextMenu" name="popupShowContextMenu">
<label data-i18n="__MSG_optionPopupShowContextMenu__" for="popupIconShowContextMenu">Show context menu item for selected text</label>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All __MSG things need localisation. (At least the English one if you speak no other language.) See this answer again and this doc.

</div>
</li>
</ul>
</section>

Expand Down
2 changes: 2 additions & 0 deletions src/options/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ RandomTips.init(tips).then(() => {
RandomTips.setContext("options");
RandomTips.showRandomTipIfWanted();
});

document.getElementById("popupShowContextMenu").checked = true;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this is not how we do it in this project. See this answer and this doc (also consider to read the whole one). You have to define the default setting in DefaultSettings.js.