Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch translation #303

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Dutch translation #303

merged 1 commit into from
Jul 8, 2024

Conversation

iw0nderhow
Copy link
Contributor

@iw0nderhow iw0nderhow commented Mar 23, 2023

Here's a Dutch translation. Might be a bit wonky due to the fact that I'm not a native Dutch speaker, but I think it's fine. ^^

I've left some links untranslated because there are no Dutch equivalents.

@rugk rugk added the i18n/l10n Internationalisation and localisation label May 9, 2023
@rugk
Copy link
Owner

rugk commented May 9, 2023

Hi @iw0nderhow,,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

Please notice there are more things to translate like the add-on listings on AMO (addons.mozilla.org) etc. See the contributing guide for more information.

BTW: Next time, try to avoid doing a pull request from the master branch, because you can run into problems when you have a "non-clean" master that does not follow this repo here (i.e. "upstream"). See this article for details. Anyway, this is only a tip for the next time. 😃

Also note if you want you can also write the Changelog entry already, just copy an existing one as explained as a side-note here.

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll give it some time for you to make changes or others to review it. As already said, you can also add yourself to the CONTRIBUTORS file and the changelog.

Also notice there are more things to translate like the add-on listings on AMO (addons.mozilla.org) etc. See the contributing guide for more information.

Actually, if you want to be great you could try out the development version and report back whether it/everything works/you like it or what may still be adjusted, so I can do this before the next release. In case there is something to be done… 😄

Just so we know the translation works good in the browser when it is actually used.

If all is done, please subscribe to #138 to get notified for new updates on translations etc. 😃

@rugk rugk merged commit baa24ee into rugk:master Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n/l10n Internationalisation and localisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants