-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spanish translations with a few orthographic corrections #326
Conversation
Hi @dverbru, Please subscribe to #138 to get notified for new updates on translations etc. 😃 BTW you can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body. (Manually linked it now.) Also notice there are more things to translate like the add-on listings on AMO (addons.mozilla.org) etc. See the contributing guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a potential review from @Fanksies and @bryancalisto. Unless there are objections, this will be merged soon.
@dverbru
To honor your work, you should be credited in the extension. To do that, you need to provide your name and a link in the extension.
You can credit yourself here and provide a link (in translatorLink
) and a name (in translatorUsername
). Also, you should add yourself to the CONTRIBUTORS.md file and the changelog as a translator to give credits here.
See https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#translations for how these placeholders are translated, especially the official doc.
BTW note if you want you can also write the Changelog entry already, just copy an existing one as explained as a side-note here.
Added myself to CONTRIBUTORS file, thanks. Anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Question marks consistent with Spanish conventions and overall semantically correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, thanks a lot to everybody involved!
#325