Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating to swedish #327

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Conversation

HannesAlexandersson
Copy link
Contributor

I have added swedish versions of message.json in a sv folder in locales.
I ahve added myself to the contributers list.
I have added a sv folder in assets/texts and translated the files. The changelogs I only translated the 2 latest.

Thanks for letting me contribute, this was my first ever time!

@rugk rugk added the i18n/l10n Internationalisation and localisation label Sep 4, 2024
@rugk
Copy link
Owner

rugk commented Sep 4, 2024

Hi @HannesAlexandersson,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

Please subscribe to #138 to get notified for new updates on translations etc. 😃

@@ -0,0 +1,9 @@
* **Featured:** Save QR code size manually or automatically.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you don't need to copy non-translated files, you can just ignore/delete them. But it's fine, if you want remove them though… 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I went ahead and just translated them all, i figured I might aswell do that.

src/_locales/sv/messages.json Outdated Show resolved Hide resolved
request, now using correct placeholder link.
translated changelogs and their .md
Copy link
Contributor Author

@HannesAlexandersson HannesAlexandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have adjusted the message.json so it now correctly uses the placeholder links
Skärmbild 2024-09-04 164823

I also translated the changelogs instead of deleting the ones that where not translated before.

@HannesAlexandersson
Copy link
Contributor Author

HannesAlexandersson commented Sep 4, 2024 via email

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Yeah you did everything correctly, better than many others, possibly hehe.

This will be released with the next update. 🙂

@rugk rugk merged commit 3ad531c into rugk:master Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n/l10n Internationalisation and localisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants