-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translating to swedish #327
Conversation
Translated the messages.json to swedish.
Adding myself to contributers as translater
translating to swedish
translating to swedish
Hi @HannesAlexandersson, Please subscribe to #138 to get notified for new updates on translations etc. 😃 |
assets/texts/sv/Changelog/1.1.md
Outdated
@@ -0,0 +1,9 @@ | |||
* **Featured:** Save QR code size manually or automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you don't need to copy non-translated files, you can just ignore/delete them. But it's fine, if you want remove them though… 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I went ahead and just translated them all, i figured I might aswell do that.
request, now using correct placeholder link. translated changelogs and their .md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thanks for the feedback. This is actually my very first time
contributing to open source and Im not sure to what to do now? Ive
completed the requested changes in a codespace at github and committed the
changes aswell as "reviewed" them. I think I have correctly submitted the
changes but please let me know if I didnt do it correctly.
Best of days to you // Hannes
Den ons 4 sep. 2024 kl 13:10 skrev rugk ***@***.***>:
… ***@***.**** requested changes on this pull request.
------------------------------
In assets/texts/sv/Changelog/1.1.md
<#327 (comment)>:
> @@ -0,0 +1,9 @@
+* **Featured:** Save QR code size manually or automatically.
Note you don't need to copy non-translated files, you can just
ignore/delete them. But it's fine, if you want remove them though… 🙂
------------------------------
In src/_locales/sv/messages.json
<#327 (comment)>:
> + "optionUseMonospaceFont": {
+ "message": "Använd monospace font",
+ "description": "This is an option shown in the add-on settings."
+ },
+
+ "optionDebugMode": {
+ "message": "Aktivera debug läge",
+ "description": "This is an option shown in the add-on settings."
+ },
+ "optionDebugModeDescr": {
+ "message": "Detta är endast användbart för att få mer detaljerad loggning i konsolen för att rapportera buggar, osv.",
+ "description": "The description shown for the debug mode (optionDebugMode)."
+ },
+
+ "translatorCredit": {
+ "message": "Detta tillägg har översatts till svenska av Hannes Alexandersson ***@***.***) .",
Basically please keep the placeholder ($…$) here in order to have a real
link to click on.
See
https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#translations
for how these placeholders are translated, especially the official doc
<https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/Internationalization#Providing_localized_strings_in__locales>
.
Actually, it is possible if you could try out the development version
<https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#coding>
you can see how that all works and if it works for you.
Just so we know the translation works good in the browser when it is
actually used.
—
Reply to this email directly, view it on GitHub
<#327 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAHBQFFQV2AER33PQRRPAOLZU3TCBAVCNFSM6AAAAABNQ6Z4YGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZZG44DANJXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Yeah you did everything correctly, better than many others, possibly hehe.
This will be released with the next update. 🙂
I have added swedish versions of message.json in a sv folder in locales.
I ahve added myself to the contributers list.
I have added a sv folder in assets/texts and translated the files. The changelogs I only translated the 2 latest.
Thanks for letting me contribute, this was my first ever time!