Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the public API to support winit 0.30
One thing to note is that I moved the "update" logic from AboutToWait to RedrawRequested.
This isn't optimal, as it doesn't call update if there is no redrawing. So a hello world app that never triggers a redraw would also not respond to quit events and such.
Using
AboutToWait
comes with a different issue https://docs.rs/winit/latest/winit/application/trait.ApplicationHandler.html#method.about_to_waitI'm not entirely sure what the best option here is.